[cosmosdb] az cosmosdb restore: Support enabling/disabling public network access
#27175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
cosmosdb |
microsoft-github-policy-service
bot
requested review from
AllyW,
jsntcy,
kairu-ms,
necusjz and
yonzhan
Contributor
|
Thank you for your contribution mayankkatwal! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
customer-reported
microsoft-github-policy-service
bot
added
Network
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| cosmosdb restore | cmd cosmosdb restore added parameter public_network_access |
mayankkatwal
changed the title
az cosmosdb restore Add new parameter to restore command: public-network-accessaz cosmosdb restore Add new parameter 'public-network-access' to restore command
mayankkatwal
changed the title
az cosmosdb restore Add new parameter 'public-network-access' to restore commandaz cosmosdb restore Add new parameter 'public-network-access'
mayankkatwal
changed the title
az cosmosdb restore Add new parameter 'public-network-access'az cosmosdb restore Add new parameter 'public-network-access'
mayankkatwal
changed the title
az cosmosdb restore Add new parameter 'public-network-access'az cosmosdb restore Add New Parameter 'Public-Network-Access'
evelyn-ys
changed the title
az cosmosdb restore Add New Parameter 'Public-Network-Access'az cosmosdb restore: Add New Parameter 'Public-Network-Access'
evelyn-ys
changed the title
az cosmosdb restore: Add New Parameter 'Public-Network-Access'az cosmosdb restore: Support enabling/disabling public network access
evelyn-ys
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az cosmosdb restore --target-database-account-name --account-name --restore-timestamp -g --location --enable-public-network <TRUE/FALSE>
Description
This pr is to add a parameter (--public-network-access) to the az cosmos db restore cli command. This change requires NO sdk/api changes as this parameter is already existing and used by (create cosmos db cli command). The change is very minor and I have updated one of our tests to take in the parameter & captured its recording.
Testing Guide
self.cmd('az cosmosdb restore -n {restored_acc} -g {rg} -a {acc} --restore-timestamp {rts} --location {loc} --assign-identity {user_id_2} --default-identity {default_id2} --public-network-access "DISABLED"')
This will restore the cosmos db account with Public Network Access as disabled.
History Notes
[cosmosdb]
az cosmosdb restore: Support enabling/disabling public network accessThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.